[Date Prev] [Date Index] [Date Next] [Thread Prev] [Thread Index] [Thread Next]

Re: Line-oriented timestamps in conserver 7.0.2

Bryan Stansell bryan@conserver.com
Tue, 3 Jul 2001 11:17:34 -0700 (PDT)


On Tue, Jul 03, 2001 at 12:55:12PM -0400, Matthew Cheek wrote:
> I just upgraded from 6.15 to 7.0.2 and was looking forward to
> line-oriented timestamps in the logs. I set the logging to "1l" (one-el)
> to get the timestamp on every line of console output. However, I see
> some peculiar behavior with this setting. Here is a sample session with

> Anyone have any ideas?

Oy!  Talk about feeling like an idiot - I let the code out with an "off
by 1" bug.  Here's a patch for 7.0.2 that fixes the bug (and it is only
if line-oriented timestamps are enabled).  Sorry about that folks.
Thanks for testing the code Matt!  :-/

*** conserver-7.0.2/conserver/group.c.old       Fri Jun 15 11:34:18 2001
--- conserver-7.0.2/conserver/group.c   Tue Jul  3 11:12:56 2001
***************
*** 272,279 ****
            }
        }
      }
!     if ( i <= j ) {
!       (void)write(pCE->fdlog, s+i, j-i+1);
      }
  }

--- 272,279 ----
            }
        }
      }
!     if ( i < j ) {
!       (void)write(pCE->fdlog, s+i, j-i);
      }
  }

Bryan